lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Dec 2006 10:32:39 +0000 From: Christoph Hellwig <hch@...radead.org> To: Ivo van Doorn <ivdoorn@...il.com> Cc: Dmitry Torokhov <dtor@...ightbb.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, John Linville <linville@...driver.com>, Jiri Benc <jbenc@...e.cz>, Lennart Poettering <lennart@...ttering.net>, Johannes Berg <johannes@...solutions.net>, Larry Finger <Larry.Finger@...inger.net> Subject: Re: [RFC] rfkill - Add support for input key to control wireless radio > +/* > + * Function called by the key driver when the rfkill structure > + * needs to be registered. > + */ > +int rfkill_register_key(struct rfkill *rfkill, int init_status) > +{ > + struct rfkill_type *type = &master->type[rfkill->key_type]; > + struct rfkill_key *key; > + int status; > + > + if (!rfkill) > + return -EINVAL; > + > + if (rfkill->key_type >= KEY_TYPE_MAX) > + return -EINVAL; > + > + /* > + * Increase module use count to prevent this > + * module to be unloaded while there are still > + * registered keys. > + */ > + if (!try_module_get(THIS_MODULE)) > + return -EBUSY; This is obviously broken. Please add a "struct module *owner;" field to struct rfkill instead. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists