linux-kernel - Re: [PATCH] Export current_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Dec 2006 09:58:09 -0800 (PST)
From:	Linus Torvalds <torvalds@...l.org>
To:	David Howells <dhowells@...hat.com>
cc:	Andrew Morton <akpm@...l.org>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Roland Dreier <rdreier@...co.com>,
	Andy Fleming <afleming@...escale.com>,
	Ben Collins <ben.collins@...ntu.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jeff Garzik <jeff@...zik.org>
Subject: Re: [PATCH] Export current_is_keventd() for libphy 



On Wed, 6 Dec 2006, Linus Torvalds wrote:
> 
> Gcc should do it for us, afaik. I didn't check, but gcc is generally 
> pretty good at combining logical operations like this, because it's very 
> common.

Sadly, gcc doesn't do it in this case. Still, I'd rather keep the source 
clean, and hope that the compiler improves eventually, than to make the 
code uglier.

I replaced both of the "test_bit(WORK_STRUCT_PENDING, &work->management)" 
with "work_pending(work)" in my tree.

Now somebody who knows how to trigger this thing should just _test_ it.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/