linux-kernel - Re: cmpxchg() in kernel/workqueue.c breaks things

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 07 Dec 2006 11:46:24 +0000
From:	David Howells <dhowells@...hat.com>
To:	Andrew Morton <akpm@...l.org>
Cc:	David Howells <dhowells@...hat.com>,
	David Miller <davem@...emloft.net>, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: cmpxchg() in kernel/workqueue.c breaks things 

Andrew Morton <akpm@...l.org> wrote:

> I don't see why the 2.6.19 logic needed changing.
> 
> a) Nobody should be freeing the work_struct itself without running
>    flush_scheduled_work() and
> 
> b) even if the work_struct _did_ get freed, the callback function won't
>    care, because there's nothing in that work_struct which it's interested
>    in.

Erm...  Did you mean that in reply to my suggestion that we don't need to use
cmpxchg()?

We might want to avoid cmpxchg() because it isn't available on all platforms
under all circumstances, and besides I'm not sure it's actually necessary.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/