linux-kernel - Re: [PATCH 1/5] PCI MMConfig: Share what's shareable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Dec 2006 17:35:06 +0200
From:	Muli Ben-Yehuda <muli@...ibm.com>
To:	Olivier Galibert <galibert@...ox.com>
Cc:	Andi Kleen <ak@...e.de>, linux-pci@...ey.karlin.mff.cuni.cz,
	"Hack inc." <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...l.org>
Subject: Re: [PATCH 1/5] PCI MMConfig: Share what's shareable.

On Thu, Dec 07, 2006 at 04:19:41PM +0100, Olivier Galibert wrote:
> On Thu, Dec 07, 2006 at 05:00:23PM +0200, Muli Ben-Yehuda wrote:
> > On Thu, Dec 07, 2006 at 03:49:53PM +0100, Olivier Galibert wrote:
> > 
> > > +void __init pci_mmcfg_init(int type)
> > > +{
> > > +	extern int pci_mmcfg_arch_init(void);
> > 
> > Please put this in a suitable header file.
> 
> Sure, which ?

arch/i386/pci/pci.h seems the least-inappropriate.

Also, forgot to mention, please get rid of C++ style comments in the
code.

Cheers,
Muli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/