linux-kernel - Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 9 Dec 2006 13:58:29 -0800
From:	Andrew Morton <akpm@...l.org>
To:	Olivier Galibert <galibert@...ox.com>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Jean Delvare <khali@...ux-fr.org>,
	Paul Mackerras <paulus@...ba.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: sysfs file creation result nightmare (WAS radeonfb: Fix
 sysfs_create_bin_file warnings)

On Sat, 9 Dec 2006 22:44:53 +0100
Olivier Galibert <galibert@...ox.com> wrote:

> On Sat, Dec 09, 2006 at 12:38:17PM -0800, Andrew Morton wrote:
> > On Sun, 10 Dec 2006 06:59:10 +1100
> > Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:
> > > Why would I prevent the framebuffer from initializing (and thus a
> > > console to be displayed at all on many machines) just because for some
> > > reason, I couldn't create a pair of EDID files in sysfs that are not
> > > even very useful anymore ?
> > 
> > Because there's a bug in your kernel.  We don't hide and work around bugs.
> 
> Hmmm, I don't understand.  Which is the bug, having a sysfs file
> creation fail or going on if it happens?

Probably the former, probably the latter.

There may be situations in which we want do to "create this sysfs file if
it doesn't already exist", but I'm not aware of any such.

Generally speaking, if sysfs file creation went wrong, it's due to a bug. 
The result is that the driver isn't working as intended: tunables or
instrumentation which it is designed to make available are not present.  We
want to know about that bug asap so we can get it fixed.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/