linux-kernel - Re: Mark bitrevX() functions as const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Dec 2006 14:22:30 +0000
From:	David Howells <dhowells@...hat.com>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	David Howells <dhowells@...hat.com>, torvalds@...l.org,
	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: Mark bitrevX() functions as const 

Akinobu Mita <akinobu.mita@...il.com> wrote:

> __attribute_pure__ ?

I'm not sure "pure" is better than const in this case.  Although it *does* look
at a global variable (byte_rev_table), that variable is constant.  In effect,
the functions output does only depend on its input.  The R/O data it requires
is no different to its out of line code.  You'd have to consult a compiler
wrangler to be sure, though.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/