lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 Dec 2006 01:07:02 +0000 From: Al Viro <viro@....linux.org.uk> To: Pavel Machek <pavel@....cz> Cc: rmk@....linux.org.uk, rpurdie@...ys.net, lenz@...wisc.edu, kernel list <linux-kernel@...r.kernel.org>, Russell King <rmk@....linux.org.uk>, Dirk@...er-Online.de, arminlitzel@....de, pavel.urban@...cz, metan@...nam.cz Subject: Re: Nasty warnings on arm (+ one compile problem -- INIT_WORK related) On Sat, Dec 16, 2006 at 12:58:18AM +0100, Pavel Machek wrote: > Hi! > > I get nasty warning for each file compiled: > > CC drivers/video/sa1100fb.o > In file included from include/asm/bitops.h:23, > from include/linux/bitops.h:9, > from include/linux/thread_info.h:20, > from include/linux/preempt.h:9, > from include/linux/spinlock.h:49, > from include/linux/module.h:9, > from drivers/video/sa1100fb.c:163: > include/asm/system.h: In function `adjust_cr': > include/asm/system.h:185: warning: implicit declaration of function > `local_irq_save' > include/asm/system.h:192: warning: implicit declaration of function > `local_irq_restore' > include/asm/system.h:179: warning: unused variable `cr' That's dealt with by the following: Signed-off-by: Al Viro <viro@...iv.linux.org.uk> --- diff --git a/include/asm-arm/system.h b/include/asm-arm/system.h index e160aeb..bf44782 100644 --- a/include/asm-arm/system.h +++ b/include/asm-arm/system.h @@ -173,10 +173,12 @@ static inline void set_copro_access(unsi extern unsigned long cr_no_alignment; /* defined in entry-armv.S */ extern unsigned long cr_alignment; /* defined in entry-armv.S */ +#include <linux/irqflags.h> + #ifndef CONFIG_SMP static inline void adjust_cr(unsigned long mask, unsigned long set) { - unsigned long flags, cr; + unsigned long flags; mask &= ~CR_A; @@ -248,8 +250,6 @@ static inline void sched_cacheflush(void { } -#include <linux/irqflags.h> - #ifdef CONFIG_SMP #define smp_mb() mb() - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists