[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 1 Jan 2007 14:05:38 -0500
From: Dave Jones <davej@...hat.com>
To: "Robert P. J. Day" <rpjday@...dspring.com>
Cc: Arjan van de Ven <arjan@...radead.org>,
Folkert van Heusden <folkert@...heusden.com>,
Paul Mundt <lethal@...ux-sh.org>,
Denis Vlasenko <vda.linux@...glemail.com>,
Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?
On Mon, Jan 01, 2007 at 05:27:10AM -0500, Robert P. J. Day wrote:
> > both look good... I'd be in favor of this. Maybe also add a part
> > about using GFP_KERNEL whenever possible, GFP_NOFS from filesystem
> > writeout code and GFP_NOIO from block writeout code (and never doing
> > in_interrupt()?GFP_ATOMIC:GFP_KERNEL !)
>
> it strikes me that that latter part is starting to go beyond the scope
> of simple coding style aesthetics and getting into actual coding
> distinctions. would that really be appropriate for the CodingStyle
> doc? i'm just asking.
Adding a separate 'good practices' doc wouldn't be a bad idea.
Dave
--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists