lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 08 Jan 2007 18:37:11 -0800
From:	Arjan van de Ven <arjan@...radead.org>
To:	thomas@...gstengraphics.com
Cc:	davej@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: agpgart: drm-populated memory types


> 
> A short recap why I belive the kmalloc / vmalloc construct is necessary:
> 
> 0) The current code uses vmalloc only.
> 1) The allocated area ranges from 4 bytes possibly up to 512 kB, depending on
> on the size of the AGP buffer allocated.
> 2) Large buffers are very few. Small buffers tend to be quite many. 
>    If we continue to use vmalloc only or another page-based scheme we will
>    waste approx one page per buffer, together with the added slowness of
>    vmalloc. This will severely hurt applications with a lot of small
>    texture buffers.
> 
> Please let me know if you still consider this unacceptable.

explicit use of either kmalloc/vmalloc is fine with me; I would suggest
an 2*PAGE_SIZE cutoff for this decision

>  
> In that case I suggest sticking with vmalloc for now.
> 
> Also please let me know if there are other parths of the patch that should be
> reworked.
> 
> The patch that follows is against Dave's agpgart repo.
> 
<you forgot the patch>

-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ