linux-kernel - Re: [PATCH/RFC 2.6.21 2/5] ehca: ehca

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Jan 2007 11:54:58 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Hoang-Nam Nguyen <hnguyen@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org,
	openfabrics-ewg@...nib.org, openib-general@...nib.org,
	raisch@...ibm.com
Subject: Re: [PATCH/RFC 2.6.21 2/5] ehca: ehca_uverbs.c: "proper" use of mmap

 > >  int ehca_mmap(struct ib_ucontext *context, struct vm_area_struct *vma)
 > >  {
 > 
 > Can you split this monster routine into individual functions for
 > each type of mmap please?  With two helpers to get and verify the cq/qp
 > shared by the individual sub-variants, that would also help to get rid
 > of all those magic offsets.
 > 
 > Actually, this routine directly comes from ib_device.mmap - Roland,
 > can you shed some light on what's going on here?

Each userspace-accessible IB device gets a single device node like
/dev/infiniband/uverbsX.  Opening that gives userspace a "context".
One of the things userspace can do with that fd is mmap() on it --
that was originally envisioned as a way to map a page of hardware
registers directly in to the userspace process.

It seems ehca needs to allocate lots of different things in the kernel
via mmap().  What you're saying I guess is that ideally each of these
would be mmap() on a different fd rather than using different
offsets.  It's a little awkward to open multiple device nodes to get
multiple fds, since there's not a good way to attach them all to the
same context.  I guess we could create some hack to return more file
handles, but I think that cure is worse than the disease of using
magic offsets...

Maybe longer term we need to look at a scheme like cell's spufs but
I'm still not confident we have the RDMA interface quite ready to
freeze at the system call level.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/