linux-kernel - Re: [PATCH 18/19] ide: add ide_use_fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Jan 2007 15:00:30 +0100
From:	"Bartlomiej Zolnierkiewicz" <bzolnier@...il.com>
To:	Alan <alan@...rguk.ukuu.org.uk>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

On 1/12/07, Alan <alan@...rguk.ukuu.org.uk> wrote:
> On Fri, 12 Jan 2007 05:28:00 +0100
> Bartlomiej Zolnierkiewicz <bzolnier@...il.com> wrote:
>
> > [PATCH] ide: add ide_use_fast_pio() helper
> >
> > * add ide_use_fast_pio() helper for use by host drivers
> > * add DMA capability and autodma checks to ide_use_dma()
> >   - au1xxx-ide/it8213/it821x drivers didn't check for (id->capability & 1)
>
> For the IT8211/2 in SMART this check shouldn't be made.

It is OK since in it821x_fixups() we set it explicitly:

		if(strstr(id->model, "Integrated Technology Express")) {
			/* In raid mode the ident block is slightly buggy
			   We need to set the bits so that the IDE layer knows
			   LBA28. LBA48 and DMA ar valid */
			id->capability |= 3;		/* LBA28, DMA */

and we are better off using generic helper if we can
(which may later allow us to use generic tuning code).

> >   - ide-cris driver didn't set ->autodma
>
> You've changed the behaviour there. Should the default be autodma=0 ?

Before my patch hwif->autodma was only checked in the chipset specific
hwif->ide_dma_check implementations.  For ide-cris it is
cris_dma_check()
function so there no behavior change here.

Sorry for not explaining changes in detail in the patch description
(I will update it).

Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/