linux-kernel - Re: [PATCH 18/19] ide: add ide_use_fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Jan 2007 15:16:29 +0000
From:	Alan <alan@...rguk.ukuu.org.uk>
To:	"Bartlomiej Zolnierkiewicz" <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

> It seems that it821x_tune_chipset() is buggy since it sends SET FEATURES
> command even when in smart mode.  Shouldn't there be "don't tune" flag
> in it812x_fixups() to tell it821x_tune_chipset() to not send SET FEATURES
> commands?

It's itdev->smart but falls through to ide_config_drive_speed while it
should probably just copy bits of the code from it. Thats all fixed in
the libata driver which allows chip specific mode setup.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/