linux-kernel - Re: [PATCH] Centralize the macro definition of "_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Jan 2007 17:48:53 +0100 (CET)
From:	Tim Schmielau <tim@...sik3.uni-rostock.de>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
cc:	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Roman Zippel <zippel@...ux-m68k.org>
Subject: Re: [PATCH]  Centralize the macro definition of "__packed".

On Thu, 18 Jan 2007, Robert P. J. Day wrote:

>   Centralize the attribute macro definition of "__packed" so no
> subsystem has to do that explicitly.
> 
> Signed-off-by: Robert P. J. Day <rpjday@...dspring.com>
> 
> ---
> 
>   compile tested to make sure the HFS subsystem still builds.  now
> there's just 50 gazillion usages of "__attribute__((packed))" that can
> be tightened up.
> 
> 
>  fs/hfs/hfs.h                 |    2 --
>  fs/hfsplus/hfsplus_raw.h     |    2 --
>  include/linux/compiler-gcc.h |    1 +
>  3 files changed, 1 insertion(+), 4 deletions(-)

Moving definitions into compiler-gcc.h only will screw non-gcc compilers 
like icc.
They should probably go into the generic section of compiler.h instead.

Tim
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/