linux-kernel - Re: problems with latest smbfs changes on 2.4.34 and security backports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Jan 2007 05:21:16 +0100
From:	Willy Tarreau <w@....eu>
To:	Grant Coady <gcoady.lk@...il.com>
Cc:	Santiago Garcia Mantinan <manty@...ian.org>,
	linux-kernel@...r.kernel.org, debian-kernel@...ts.debian.org,
	dannf@...nf.org
Subject: Re: problems with latest smbfs changes on 2.4.34 and security backports

Hi Grant !

On Thu, Jan 18, 2007 at 11:09:57AM +1100, Grant Coady wrote:
(...)
> > 	} else {
> >-		mnt->file_mode = mnt->dir_mode = S_IRWXU | S_IRGRP | S_IXGRP |
> >-						S_IROTH | S_IXOTH | S_IFREG;
> >-		mnt->dir_mode = mnt->dir_mode = S_IRWXU | S_IRGRP | S_IXGRP |
> >-						S_IROTH | S_IXOTH | S_IFDIR;
> >+		mnt->file_mode = S_IRWXU | S_IRGRP | S_IXGRP |
> >+				S_IROTH | S_IXOTH | S_IFREG | S_IFLNK;
> >+		mnt->dir_mode = S_IRWXU | S_IRGRP | S_IXGRP |
> >+				S_IROTH | S_IXOTH | S_IFDIR;
> > 		if (parse_options(mnt, raw_data))
> > 			goto out_bad_option;
> 
> I'm comparing 2.4.33.3 with 2.4.34, with 2.4.34 and above patch symlinks 
> to directories seen as target, nor can they be created (Operation not 
> permitted...)

Thanks very much Grant for the test. Could you try a symlink to a file ?
And while we're at it, would you like to try to add "|S_IFLNK" to
mnt->dir_mode ? If my suggestion was stupid, at least let's test it to
full extent ;-)

I had another idea looking at the code but since I really don't know it,
I would not like to propose random changes till this magically works. I'd
wait for Dann who understood the code.

Best regards,
Willy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/