linux-kernel - [patch] remove __devinit markings from rtc_sysfs_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 20 Jan 2007 11:11:02 -0500
From:	Mike Frysinger <vapier@...too.org>
To:	a.zummo@...ertech.it
Cc:	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com
Subject: [patch] remove __devinit markings from rtc_sysfs_add_device()

the sysfs interface from the rtc framework seems to incorrectly label the add 
function with __devinit ... the proc and dev interfaces do not have this 
label on their add functions

ive been trying to develop a rtc module and it kept crashing ... after 
debugging it, i'm pretty sure ive traced it back to the devinit markings ... 
dropping this lets my module load nicely :)

the crash would happen after my rtc called rtc_device_register ... down in 
class_device_add in drivers/base/class.c, the active class interface list is 
walked and the add function is checked ... if it's non-null (aka in some 
interface would like to be notified of additions), then it's called with the 
new device information

on my board, this add pointer would seemingly point into garbage because the 
memory it refers to was freed by the kernel :(
-mike

Content of type "application/pgp-signature" skipped

View attachment "linux-rtc-sysfs-no-devinit-add.patch" of type "text/x-diff" (578 bytes)