linux-kernel - identifying CONFIG variable typoes in the source tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Jan 2007 16:13:43 -0500 (EST)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: identifying CONFIG variable typoes in the source tree

  because it's cold outside and i was bored, i put together the
following script, to be run from the top of the source tree:

======================================================B
#!/bin/sh

CV=$(grep -rh "^#.*if.* CONFIG_[A-Za-z0-9]" . | grep -v endif)
CVARS=$(echo "${CV}" | sed "s/.*\(CONFIG_[^	 =\)\*\/]*\).*/\1/" | sort -u | grep "^CONFIG_")

kcfiles=$(find . -name "Kconfig*")

for cv in ${CVARS} ; do
	# echo "cv = ${cv}"
	str=$(echo ${cv} | sed "s/^CONFIG_//")
	# echo "str = ${str}"
	grep -wq ${str} ${kcfiles} || echo ${str}
done
=======================================================

  what it does is scan the entire tree for lines of the form

...if... CONFIG_whatever...

collects all of those CONFIG variables and, one at a time, checks to
see if that variable even exists in any Kconfig file in the tree so
that it could possibly ever be set.  (i'm not guaranteeing that the
script is perfect, but it does generate some interesting results.)

  the first few lines of output:

53C700_BE_BUS
64_BIT
68328_SERIAL_UART2
...

  let's check these:

$ grep -r 53C700_BE_BUS .
./drivers/scsi/53c700.h:#ifdef CONFIG_53C700_BE_BUS

  in short, a variable that's being tested with no possibility of ever
being set in a Kconfig file.  moving on,

$ grep -rw CONFIG_64_BIT .
./include/asm-um/elf-ppc.h:#ifdef CONFIG_64_BIT
$ grep -rw 64_BIT .
$

  so CONFIG_64_BIT is similarly being tested, but it's not being set
anywhere.  i'm guessing this is a misspelling of "CONFIG_64BIT", which
*does* exist in the tree and is quite common.  next:

$ grep -r 68328_SERIAL_UART2 .
./drivers/serial/68328serial.h:#ifndef CONFIG_68328_SERIAL_UART2
./arch/m68knommu/platform/68VZ328/config.c:#ifdef CONFIG_68328_SERIAL_UART2

  again, something being tested with no possibility of it being set
anywhere.

  the script turns up 284 examples of this.

rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/