[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 1 Feb 2007 16:55:53 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Christoph Lameter <clameter@....com>
Cc: Oleg Nesterov <oleg@...sign.ru>, linux-kernel@...r.kernel.org
Subject: Re: [SLAB] Shutdown cache_reaper when cpu goes down
On Thu, 1 Feb 2007 11:13:29 -0800 (PST)
Christoph Lameter <clameter@....com> wrote:
> Shutdown the cache_reaper if the cpu is brought down and set the
> cache_reap.func to NULL. Otherwise hotplug shuts down the reaper for good.
>
> Signed-off-by: Christoph Lameter <clameter@....com>
>
> Index: linux-2.6.20-rc6-mm2/mm/slab.c
> ===================================================================
> --- linux-2.6.20-rc6-mm2.orig/mm/slab.c 2007-01-29 14:27:34.199229828 -0600
> +++ linux-2.6.20-rc6-mm2/mm/slab.c 2007-01-30 13:55:57.936838878 -0600
> @@ -1271,6 +1271,18 @@ static int __cpuinit cpuup_callback(stru
> start_cpu_timer(cpu);
> break;
> #ifdef CONFIG_HOTPLUG_CPU
> + case CPU_DOWN_PREPARE:
> + /*
> + * Shutdown cache reaper. Note that the cache_chain_mutex is
> + * held so that cache_reap() cannot modify reap_work
> + * concurrently.
> + */
> + cancel_rearming_delayed_work(&per_cpu(reap_work, cpu));
> + per_cpu(reap_work, cpu).work.func = NULL;
> + break;
> + case CPU_DOWN_FAILED:
> + start_cpu_timer(cpu);
> + break;
> case CPU_DEAD:
> /*
> * Even if all the cpus of a node are down, we don't free the
Is this bug unique to the changes in -mm, or is it in mainline?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists