linux-kernel - Re: [PATCH] pci: allow multiple calls to pcim_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 21 Feb 2007 10:45:35 +1300
From:	"Ian McDonald" <ian.mcdonald@...di.co.nz>
To:	"Tejun Heo" <htejun@...il.com>
Cc:	"Bartlomiej Zolnierkiewicz" <bzolnier@...il.com>, gregkh@...e.de,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Jeff Garzik" <jeff@...zik.org>
Subject: Re: [PATCH] pci: allow multiple calls to pcim_pin_device()

On 2/20/07, Tejun Heo <htejun@...il.com> wrote:
> Sanity check in pcim_pin_device() was too restrictive in that it
> didn't allow multiple calls to the function, which is against the
> devres philosohpy of fire-and-forget.  Track pinned status separately
> and allow pinning multiple times.
>
> Signed-off-by: Tejun Heo <htejun@...il.com>
> ---
> It was an actual bug in pcim_pin_device() implementation.  Thanks for
> spotting this.  :-)
>
> Ian McDonald, please verify your warning goes away with this patch.

Yes it does. Thanks for sorting.
>
> Greg, please forward this patch upstream once Ian acks it.
>
Acked-by: Ian McDonald <ian.mcdonald@...di.co.nz>
-- 
Web: http://wand.net.nz/~iam4
Blog: http://iansblog.jandi.co.nz
WAND Network Research Group
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/