linux-kernel - Re: [PATCH] Print error code in page faults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 24 Feb 2007 14:12:29 -0500
From:	Chuck Ebbert <cebbert@...hat.com>
To:	Glauber de Oliveira Costa <gcosta@...hat.com>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, ak@...e.de
Subject: Re: [PATCH] Print error code in page faults

Glauber de Oliveira Costa wrote:
> When a page faults comes from a kernel space, the printed summary
> leaves us clueless about what kind of access was being tried (which
> is encoded in the error_code variable).
> 
> Having it promply available may ease debugging in a bunch of
> situations.
> 
> Signed-off-by: Glauber de Oliveira Costa <gcosta@...hat.com>
> 
> 
> 
> ------------------------------------------------------------------------
> 
> diff --git a/arch/x86_64/mm/fault.c b/arch/x86_64/mm/fault.c
> index 6ada723..e65522e 100644
> --- a/arch/x86_64/mm/fault.c
> +++ b/arch/x86_64/mm/fault.c
> @@ -539,7 +539,7 @@ no_context:
>  		printk(KERN_ALERT "Unable to handle kernel NULL pointer dereference");
>  	else
>  		printk(KERN_ALERT "Unable to handle kernel paging request");
> -	printk(" at %016lx RIP: \n" KERN_ALERT,address);
> +	printk(" at %016lx (error=0x%02lx) RIP: \n" KERN_ALERT, error_code, address);
>  	printk_address(regs->rip);
>  	dump_pagetable(address);
>  	tsk->thread.cr2 = address;

Umm, it's already there, right after the word "Oops".


Oops: 0002 [1] SMP
      ^^^^


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/