lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 25 Feb 2007 05:43:42 +0000 From: Christoph Hellwig <hch@...radead.org> To: David Woodhouse <dwmw2@...radead.org> Cc: Theodore Tso <tytso@....edu>, Artem Bityutskiy <dedekind@...radead.org>, Christoph Hellwig <hch@...radead.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Frank Haverkamp <haver@...t.ibm.com>, Josh Boyer <jwboyer@...ux.vnet.ibm.com>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [PATCH 05/44 take 2] [UBI] internal common header On Tue, Feb 20, 2007 at 03:15:55PM +0000, David Woodhouse wrote: > > It would be much better to use __be32 and __be64, so you get better > > type checking, and you will catch bugs caused by forgetting to use > > be32_to_cpu, et. al. > > The technique Artem uses is derived from what I do in JFFS2. It predates > the use of sparse to catch such errors, and works in gcc for _everyone_ > without having to do anything special (like run sparse). And makes the code clumsy and pointlessly different from all other code we have. While no one will force you to convert your legacy point at this code, we really shouldn't add more non-standard code. If you really want warnings from gcc directly I doubt __attribute__((bitwise)) would be hard to implement for it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists