linux-kernel - Re: [irq: Remove set_native_irq_info] !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Feb 2007 16:50:33 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Simon Arlott <58022e3be4e86309571hlooq00057abw@...nder.lp0.eu>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [irq: Remove set_native_irq_info] !CONFIG_SMP regression

Simon Arlott <simon@...ott.org> writes:

> 9f0a5ba5508143731dc63235de19659be20d26dc is first bad commit
> commit 9f0a5ba5508143731dc63235de19659be20d26dc
> Author: Eric W. Biederman <ebiederm@...ssion.com>
> Date:   Fri Feb 23 04:13:55 2007 -0700
>
>     [PATCH] irq: Remove set_native_irq_info
>
>     This patch replaces all instances of "set_native_irq_info(irq, mask)"
>     with "irq_desc[irq].affinity = mask".  The latter form is clearer
>     uses fewer abstractions, and makes access to this field uniform
>     accross different architectures.
>
>
>
> arch/i386/kernel/io_apic.c: In function `setup_IO_APIC_irqs':
> arch/i386/kernel/io_apic.c:1357: error: structure has no member named `affinity'
> arch/i386/kernel/io_apic.c: In function `io_apic_set_pci_routing':
> arch/i386/kernel/io_apic.c:2878: error: structure has no member named `affinity'
>
>
> The original version was an empty function if !CONFIG_SMP, struct irq_desc only
> has 'affinity' on SMP.

Yep.

Give me a bit. I think we can just kill those lines.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/