linux-kernel - Re: [PATCH -mm 3/5] Blackfin: on-chip ethernet MAC controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Mar 2007 13:21:27 -0500
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Stephen Hemminger" <shemminger@...ux-foundation.org>
Cc:	bryan.wu@...log.com, "Andrew Morton" <akpm@...ux-foundation.org>,
	jgarzik@...ox.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH -mm 3/5] Blackfin: on-chip ethernet MAC controller driver

On 3/1/07, Stephen Hemminger <shemminger@...ux-foundation.org> wrote:
> Wu, Bryan wrote:
> > +config BFIN_MAC
> > +     tristate "Blackfin 536/537 on-chip mac support"
> > +     depends on NET_ETHERNET && (BF537 || BF536) && (!BF537_PORT_H)
> > +     select CRC32
> > +     select BFIN_MAC_USE_L1 if DMA_UNCACHED_NONE
> > +     help
> > +       This is the driver for blackfin on-chip mac device. Say Y if you want it
> > +       compiled into the kernel. This driver is also available as a module
> > +       ( = code which can be inserted in and removed from the running kernel
> > +       whenever you want). The module will be called bfin_mac.
> > +
> > +config BFIN_MAC_USE_L1
> > +     bool "Use L1 memory for rx/tx packets"
> > +     depends on BFIN_MAC && BF537
> > +     default y
> > +     help
> > +       To get maximum network performace, you should use L1 memory as rx/tx buffers.
> > +       Say N here if you want to reserve L1 memory for other uses.
> > +
> > +config BFIN_TX_DESC_NUM
> > +     int "Number of transmit buffer packets"
> > +     depends on BFIN_MAC
> > +     range 6 10 if BFIN_MAC_USE_L1
> > +     range 10 100
> > +     default "10"
> > +     help
> > +       Set the number of buffer packets used in driver.
> > +
> > +config BFIN_RX_DESC_NUM
> > +     int "Number of receive buffer packets"
> > +     depends on BFIN_MAC
> > +     range 20 100 if BFIN_MAC_USE_L1
> > +     range 20 800
> > +     default "20"
> > +     help
> > +       Set the number of buffer packets used in driver
> >
> The regular practice is to put these in a device include file, and not
> make them kernel configurable.

we're working on moving some of this stuff into the board files rather
than Kconfig

> Why would you want to make it tuneable at compile time?

because it was easier to implement and deploy the first time around ;)
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/