linux-kernel - Re: [Linux-fbdev-devel] 2.6.21-rc2 radeon backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 Mar 2007 23:40:12 +0000
From:	Richard Purdie <rpurdie@...ys.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	James Simmons <jsimmons@...radead.org>,
	linux-fbdev-devel@...ts.sourceforge.net, romosan@...orax.lbl.gov,
	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Linux-fbdev-devel] 2.6.21-rc2 radeon backlight

On Fri, 2007-03-02 at 13:58 -0800, Andrew Morton wrote:
> > @@ -1106,7 +1105,8 @@ config FB_ATY_GX
> >  
> >  config FB_ATY_BACKLIGHT
> >  	bool "Support for backlight control"
> > -	depends on FB_ATY
> > +	depends on FB_ATY && EXPERIMENTAL
> > +	select FB_BACKLIGHT	
> >  	default y
> >  	help
> >  	  Say Y here if you want to control the backlight of your display.
> 
> Sorry, but my confidence level on this one is very low.  We've had heaps
> and heaps of Kconfig-related build errors in exactly this area.  I'd prefer
> that a patch like this one have a lot of testing and review (and a
> changelog?) before we let it near a tree.

Agreed, I can tell from what I've seen so far this will at least break
the PMAC users...

See my proposed patch, if that doesn't work, we should revert the
problematic change.

Richard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/