linux-kernel - Re: [PATCH] fix vsyscall settimeofday

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 05 Mar 2007 10:57:18 -0800
From:	john stultz <johnstul@...ibm.com>
To:	Daniel Walker <dwalker@...sta.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix vsyscall settimeofday

On Mon, 2007-03-05 at 08:56 -0800, Daniel Walker wrote:
> I've only seen this on x86_64 .
> 
> The vsyscall state only gets updated when a timer interrupts comes in . So
> if the time is set long before the next timer, there will be a period when
> a gettimeofday() won't reflect the correct time.
> 
> I added an explicit update_vsyscall() during the settimeofday(), that way
> the vsyscall state doesn't get stale.
> 
> Any thought John?

Oh! Yes, very good catch, Daniel!

Thanks so much!
-john


> Signed-Off-By: Daniel Walker <dwalker@...sta.com>

Acked-by: John Stultz <johnstul@...ibm.com>


> ---
>  kernel/timer.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: linux-2.6.20/kernel/timer.c
> ===================================================================
> --- linux-2.6.20.orig/kernel/timer.c
> +++ linux-2.6.20/kernel/timer.c
> @@ -861,6 +861,8 @@ int do_settimeofday(struct timespec *tv)
>  	clock->error = 0;
>  	ntp_clear();
> 
> +	update_vsyscall(&xtime, clock);
> +
>  	write_sequnlock_irqrestore(&xtime_lock, flags);
> 
>  	/* signal hrtimers about time change */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/