linux-kernel - Re: [PATCH] CIRRUS: Delete unused header file.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 10 Mar 2007 23:26:10 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
Cc:	linux-kernel@...r.kernel.org, twoller@...stal.cirrus.com
Subject: Re: [PATCH] CIRRUS: Delete unused header file.

> On Sat, 10 Mar 2007 17:27:44 -0500 (EST) "Robert P. J. Day" <rpjday@...dspring.com> wrote:
> 
>   Delete apparently unused header file
> sound/pci/cs46xx/imgs/cwcemb80.h.
> 

That patch series was rather a mess

- Multiple patches with the same Subject: (I might have lost some as a result)

- Several patches which tried to remove the same header file

- Several patches which simply didn't apply

- Inconsisent changelogging, inconsistent titling

- Lack of sequence numbering (again, contributes to possible patch loss)

- Useless indenting in changleog text which I have to edit away.

We have good tools (ie: quilt) which make this sort of thing nice and easy
to get right - please use them.

I didn't check that these headers are indeed unused.  I hope you got that
minor part right..

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/