linux-kernel - Re: [PATCH] x86_64, i386: Add command line length to boot protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Mar 2007 00:12:20 +0100
From:	Pavel Machek <pavel@....cz>
To:	Dave Jones <davej@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	alon.barlev@...il.com, ak@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86_64, i386: Add command line length to boot protocol

Hi!

>  > >  > +cmdline_size:   .long   COMMAND_LINE_SIZE-1     #length of the command line,
>  > > 
>  > > Why a long? It's unlikely that someone is going to have a command line
>  > > bigger than 0xffff.
>  > 
>  > Well, I could imagine overflowing that. Describing your numa setup,
>  > excluding few bad bits of ram using memmap=exact, set up your boot
>  > over iscsi on cmdline.... these are likely to eat insane ammount of
>  > cmdline space.
> 
> 65535 characters? Are you for real?
> Stop and think about just how big that is. If you have to create
> a boot command line that long, you have serious, serious issues.

Well, it is about the same size as my .config...

I agree we are unlikely to hit it any time soon... I could imagine
some (ab)uses, like fixed_acpi_bios=<lots of hex digits>, but those
are ugly. I could also imagine some uses where entire embedded machine
is described at kernel commandline.

Yes, all those are ugly/unlikely. OTOH saving 2 bytes does not seem
like that great goal.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/