linux-kernel - Re: [PATCH 0/2] wistron

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Mar 2007 11:26:59 +0100
From:	Éric Piel <Eric.Piel@...mplin-utc.net>
To:	Vojtech Pavlik <vojtech@...e.cz>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>, mitr@...ny.cz,
	otauber@....de, linux-kernel@...r.kernel.org,
	linux-input <linux-input@...ey.karlin.mff.cuni.cz>
Subject: Re: [PATCH 0/2] wistron_btns: More keymaps

03/14/2007 08:02 PM, Vojtech Pavlik wrote/a écrit:
> On Wed, Mar 14, 2007 at 02:58:49PM -0400, Dmitry Torokhov wrote:
> 
>>>> 2. I also have a concern about using KEY_SCREEN to signal toggling
>>>> display on and off. I am CCing Vojtech - he must know what the
>>>> original intent of this key code was. BTW, when user presses
>>>> corresponding button - does the display actually goes off? Maybe we
>>>> need another switch.
>>> Sorry, Dmitry, I probably should have documented it back then, I don't
>>> have the slightest idea anymore.
>>>
>> That's what I was afraid of ;) Well, maybe we should just use it to
>> indicate display switch and add a comment to that effect to input.h...
> 
> Digging somewhat deeper into my memory, I think it just so happened that
> there was a keyboard with a key with a pictogram of a computer screen on
> it with no really defined purpose. Since at that time there was only a
> limited number of different extended keyboard types, it was added.
> 
> I think it'd make sense to use it eg. for the key that switches between
> internal and external output on laptops, if the laptop generates a
> keycode for the key at all. But maybe that function is already taken by
> KEY_SWITCHVIDEOMODE ...

Ok, so let me summarize:

There are two kinds of keys on those laptops (for which we are not sure 
about the keycode that it should generate):
* Laptop screen on/off
* Display output selection (for instance: laptop/external/both)

The possible keycodes that we could assign to them:
KEY_SCREEN
KEY_MEDIA
KEY_MODE
KEY_VIDEO
KEY_SWITCHVIDEOMODE
KEY_COMPUTER
KEY_PC

 From the discussion, I had the feeling this association would be the 
less incorrect:
Screen on/off : KEY_SCREEN
Display selection : KEY_SWITCHVIDEOMODE

Is that ok with everyone? If not, please suggest something better ;-)

See you,
Eric

PS: So far, I believe that for all laptops, those keys are just normal 
keys (as opposed to a key which would also do by itself its intended 
action).  At least on a 3020, pressing "screen on/off" doesn't 
automatically switch on/off the screen.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/