linux-kernel - [PATCH][2/5][resend] floppy.c: Remove pointless register keywords

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 19 Mar 2007 16:10:29 +0100
From:	Jesper Juhl <jesper.juhl@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...e.de>,
	Trent Waddington <trent.waddington@...il.com>,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Jesper Juhl <jesper.juhl@...il.com>
Subject: [PATCH][2/5][resend] floppy.c: Remove pointless register keywords


    This patch removes the use of the 'register' keyword from floppy.c
    
    Marking some variables 'register' may have made sense in the past (though I
    doubt it for these ones), but these days I very much suspect that we would
    rather grant gcc more freedom in how to handle the variables and I doubt
    very much that in this day and age optimizing access to variables via
    'register' makes any sense for a floppy driver.  Let's just get rid of it.
    
Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
Acked-by: Alan Cox <alan@...hat.com>
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
---

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 5da54b8..dea7c4f 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -791,7 +791,7 @@ static inline int is_selected(int dor, int unit)
 
 static int set_dor(int fdc, char mask, char data)
 {
-	register unsigned char drive, unit, newdor, olddor;
+	unsigned char drive, unit, newdor, olddor;
 
 	if (FDCS->address == -1)
 		return -1;
@@ -946,7 +946,7 @@ static void motor_off_callback(unsigned long nr)
 static void floppy_off(unsigned int drive)
 {
 	unsigned long volatile delta;
-	register int fdc = FDC(drive);
+	int fdc = FDC(drive);
 
 	if (!(FDCS->dor & (0x10 << UNIT(drive))))
 		return;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/