linux-kernel - Re: [PATCH v3] Race between cat /proc/kallsyms and rmmod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Mar 2007 15:20:43 +0000
From:	Paulo Marques <pmarques@...popie.com>
To:	Alexey Dobriyan <adobriyan@...ru>
CC:	akpm@...l.org, linux-kernel@...r.kernel.org, devel@...nvz.org,
	rusty@...tcorp.com.au
Subject: Re: [PATCH v3] Race between cat /proc/kallsyms and rmmod

Alexey Dobriyan wrote:
> Iterating code of /proc/kallsyms calls module_get_kallsym() which grabs
> and drops module_mutex internally and returns "struct module *",
> module is removed, aforementioned "struct module *" is used in non-trivial
> way.
> 
> Steps to reproduce:
> 
> 	modprobe/rmmod loop
> 	cat /proc/kallsyms >/dev/null loop
> 
> Copy all needed info under module_mutex.
> 
> NOTE: this patch keeps module_mutex static.

Yes, this patch fixes the "cat /proc/kallsyms" race without changing any 
"external" interfaces, so I think it should go into mainline in any case.

Acked-by: Paulo Marques <pmarques@...popie.com>

-- 
Paulo Marques - www.grupopie.com

"All I ask is a chance to prove that money can't make me happy."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/