linux-kernel - Re: [PATCH][5/5][resend] floppy.c: Fix device_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Mar 2007 12:29:49 +0100 (CET)
From:	Andreas Kleen <ak@...e.de>
To:	Mikael Pettersson <mikpe@...uu.se>
Cc:	jesper.juhl@...il.com, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, bzolnier@...il.com,
	linux-kernel@...r.kernel.org, trent.waddington@...il.com
Subject: Re: [PATCH][5/5][resend] floppy.c: Fix device_create_file() warning

> The floppy driver's sysfs file just provides some auxiliary
> information to user-space, none of which matters for most of
> its users. It is IMO totally inappropriate to fail floppy
> driver init in this case.

I thought it was for udev to create the device nodes? But
I might be wrong on that.

If it's ok to ignore such failures there sometimes then the warning
attribute should
be dropped. But just shutting the warning up is the wrong change.

Beides if floppy doesn't need sysfs for anything why does it
initialize sysfs? IMHO sysfs should be only used if there is a
good reason, otherwise it is just wasted memory.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/