linux-kernel - Re: [PATCH] Unset msi and msix flags on pci_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 21 Mar 2007 23:23:33 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Thomas Meyer <thomas@...3r.de>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Unset msi and msix flags on pci_device_disable

Thomas Meyer <thomas@...3r.de> writes:

> The commit f5f2b13129a6541debf8851bae843cbbf48298b7 broke suspend/resume
> to disk two or more  times in a row. This patches fixes the problem:

Please clue me in, on what the problem is, I see why my patch would
have changed things I don't see how it is breaking things.  Clearing
the device bits has no effect on the hardware and it leaks our
msi handling data structures.

What is the user doing that this code broke?

I will be happy to work through a proper fix but this isn't it.

If this is actually helps something I am tempted to make the
added lines say WARN_ON.....

But I would really like to understand the nature of the problem
so that we can do something to fix it properly.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/