linux-kernel - Re: [PATCH -mm 4/4] Blackfin: on-chip Two Wire Interface I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Mar 2007 01:39:28 -0400
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Jean Delvare" <khali@...ux-fr.org>
Cc:	"Bryan Wu" <bryan.wu@...log.com>,
	"David Brownell" <david-b@...bell.net>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Alexey Dobriyan" <adobriyan@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm 4/4] Blackfin: on-chip Two Wire Interface I2C driver

On 3/21/07, Jean Delvare <khali@...ux-fr.org> wrote:
> > +     p_adap->class = I2C_CLASS_ALL;
>
> This pretty much voids the point of these probing classes. You should
> only select the classes matching devices which may actually be probed
> for on this bus. If different boards have different needs, get the
> right classes from the platform data.

i asked about the class issue previously specifically for this bus
driver and was told that they werent really fully defined ... the
on-chip I2C interface on the Blackfin chip can handle any I2C device
which is why i added this line

any examples of how to go about doing it via boards ?  i dont see any
other I2C bus driver doing it that way ...
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/