linux-kernel - Re: [xfs-masters] Re: [PATCH] Cleanup and kernelify shrinker registration (rc5-mm2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Apr 2007 10:36:27 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Chinner <dgc@....com>
Cc:	xfs-masters@....sgi.com,
	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-mm@...ck.org, reiserfs-dev@...esys.com
Subject: Re: [xfs-masters] Re: [PATCH] Cleanup and kernelify shrinker
 registration (rc5-mm2)

On Tue, 3 Apr 2007 22:37:06 +1000 David Chinner <dgc@....com> wrote:

> On Tue, Apr 03, 2007 at 05:18:25PM +1000, Rusty Russell wrote:
> > On Mon, 2007-04-02 at 23:09 -0700, Andrew Morton wrote:
> > This is not about efficiency.  When have I *ever* posted optimization
> > patches?
> > 
> > This is about clarity.  We have a standard convention for
> > register/unregister.  And they can't fail.  Either of these would be
> > sufficient to justify a change.
> > 
> > Too many people doing cool new things in the kernel, not enough
> > polishing of the crap that's already there 8(
> > 
> > > But I think we need to weed that crappiness out of XFS first.
> 
> Can anyone else see the contradiction in these statements?
> 
> XFS's "crappiness" is a register/unregister interface.  The only
> reason it's being removed is because it's getting replaced with a
> nearly identical register/unregister interface.

Nope.  XFS is introducing two new typedefs, one of which is identical to
one which we already have and it has wrapper functions which do little more
than add new names for existing stuff.

What Rusty is doing is changing the API so that the caller registers a
caller-owned struct rather than registering a caller-provided function. 
For some reason.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/