linux-kernel - Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Apr 2007 12:22:59 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	David Brownell <david-b@...bell.net>
CC:	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!

David Brownell wrote:
> On Wednesday 04 April 2007 12:00 pm, Randy Dunlap wrote:
>> On Wed,  4 Apr 2007 14:05:04 -0400 Tony Lindgren wrote:
>>
>>> +static int __init fpga_init(void)
>>> +{
>>> +	if (machine_is_omap_h4()
>>> +			|| machine_is_omap_h3()
>>> +			|| machine_is_omap_h2()
>>> +			|| machine_is_omap_perseus2()
>>> +			)
>> Perhaps there is nothing in CodingStyle for if () continuation
>> lines.  Looks like it is needed.  This is ETOOMUCHINDENTATION by
>> at least one tab.  Should be more like:
>>
>> +	if (machine_is_omap_h4()
>> +	    || machine_is_omap_h3()
>> +	    || machine_is_omap_h2()
>> +	    || machine_is_omap_perseus2())
> 
> That's clearly wrong -- it uses non-tab characters for indents.

That first part is not clear at all.

> Which means that unless you think
> 
> 	if (this_longthing
> 		|| that longthing
> 		|| another
> 		...)
> 		the condition;
> 
> is correct (nope!), those additional conditions need more indents.

No, that's still ugly.

>> (without getting into where the "||" should be placed).
>>
>>> +		return platform_driver_register(&led_driver);
>>> +	return 0;
>>> +}
>>> +fs_initcall(fpga_init);
>> fs, eh?
> 
> That basically means "after subsys init and before other drivers", yes?
> For platform level init code, that's a fairly significant category.

Maybe it should have an alias then?

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/