[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 05 Apr 2007 09:14:12 +1000
From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
To: David Howells <dhowells@...hat.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
linux-arch@...r.kernel.org,
Linux Memory Management <linux-mm@...ck.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/14] get_unmapped_area handles MAP_FIXED in /dev/mem
(nommu)
On Wed, 2007-04-04 at 11:31 +0100, David Howells wrote:
> Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:
>
> > + if (flags & MAP_FIXED)
> > + if ((addr >> PAGE_SHIFT) != pgoff)
> > + return (unsigned long) -EINVAL;
>
> Again... in NOMMU-mode there is no MAP_FIXED - it's rejected before we get
> this far.
>
> > - return pgoff;
> > + return pgoff << PAGE_SHIFT;
>
> That, however, does appear to be a genuine bugfix.
I'll separate it from the rest of the patches
Ben.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists