linux-kernel - Re: [2.6 patch] the scheduled -EINVAL for invalid timevals in setitimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 06 Apr 2007 12:29:19 +0200
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] the scheduled -EINVAL for invalid timevals in
	setitimer

On Fri, 2007-04-06 at 12:20 +0200, Adrian Bunk wrote:
> As scheduled, do_setitimer() now returns -EINVAL for invalid timeval.
>
> Signed-off-by: Adrian Bunk <bunk@...sta.de>

Ha, you beat me by a minute :)

> -	check_itimerval(value);
> +	if (unlikely(!timeval_valid(&value->it_value) || !timeval_valid(&value->it_interval)))
> +		return -EINVAL;
>  

Please make this:

+       if (!timeval_valid(&value->it_value) ||
+           !timeval_valid(&value->it_interval))
+               return -EINVAL;

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/