| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 7 Apr 2007 18:39:50 -0700 From: Randy Dunlap <randy.dunlap@...cle.com> To: "John Anthony Kazos Jr." <jakj@...-k-j.com> Cc: aeb@....nl, linux-kernel@...r.kernel.org Subject: Re: [RFC] partitions: CONFIG_BLK_DEV_MD and modular RAID support On Sat, 7 Apr 2007 18:47:20 -0400 (EDT) John Anthony Kazos Jr. wrote: > (Linux v2.6.20.6.) > > The function md_autodetect_dev is defined in drivers/md/md.c. Its > declaration is on line 1443, outside of conditionals. However, both its > use on line 1455 and its definition on line 5600 are inside "#ifndef > MODULE" conditionals. So it seems obvious that the declaration should be > inside conditionals as well. > > However, this function is separately declared and used in > fs/partitions/check.c but not inside the same conditional, which means if > md.c is compiled as a module, check.c will be referencing an undefined > symbol. I don't get a build error when BLK_DEV_MD=m. Do you? Do you want to determine why there is no build error? Hint: look at include/linux/autoconf.h. > Should the conditionals around md_autodetect_dev be changed to make sure > CONFIG_BLK_DEV_MD=y, or does the function need to be extracted from md.c > so it can be used by check.c in any case? --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists