lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Apr 2007 14:00:24 +1000 From: Rusty Russell <rusty@...tcorp.com.au> To: Pekka Enberg <penberg@...helsinki.fi> Cc: Andrew Morton <akpm@...ux-foundation.org>, lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>, virtualization <virtualization@...ts.linux-foundation.org>, Andi Kleen <ak@....de>, jens.axboe@...cle.com Subject: Re: PATCH 7/8] lguest: the block driver On Tue, 2007-04-10 at 14:36 +0300, Pekka Enberg wrote: > On 4/10/07, Rusty Russell <rusty@...tcorp.com.au> wrote: > > > +/* Jens gave me this nice helper to end all chunks of a request. */ > > > +static void end_entire_request(struct request *req, int uptodate) > > > +{ > > > + if (end_that_request_first(req, uptodate, req->hard_nr_sectors)) > > > + BUG(); > > > + add_disk_randomness(req->rq_disk); > > > + blkdev_dequeue_request(req); > > > + end_that_request_last(req, uptodate); > > > +} > > On 4/10/07, Pekka Enberg <penberg@...helsinki.fi> wrote: > > Perhaps we should move this to generic code (i.e. block/ll_rw_blk.c)? Yeah, Jens said to put it in here and he'd hoist it later. > Uhm, I am bit confused now. Why don't you just use end_request() here? What a question! end_request() doesn't end a request! What a crazy idea! As far as I can tell, every name in the block layer is actually some variant of "fuck off, this is too complicated for you to understand". Hope that clarifies! Rusty. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists