linux-kernel - Re: [AppArmor 37/41] AppArmor: Main Part

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Apr 2007 18:52:15 +1000
From:	Nick Piggin <nickpiggin@...oo.com.au>
To:	Andreas Gruenbacher <agruen@...e.de>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>, jjohansen@...e.de,
	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, chrisw@...s-sol.org
Subject: Re: [AppArmor 37/41] AppArmor: Main Part

Andreas Gruenbacher wrote:
> On Thursday 12 April 2007 12:37, Alan Cox wrote:
> 
>>>+		if (PTR_ERR(sa->name) == -ENOENT && (check & AA_CHECK_FD))
>>>+			denied_mask = 0;
>>
>>Now there is an interesting question. Is PTR_ERR() safe for kernel
>>pointers on all platforms or just for user ones ?
> 
> 
> It's used for kernel pointers all over the place and mmap also mixes user 
> addresses with -Exxx, so it's definitely supposed to work. I'm not sure how 
> exactly the topmost page is kept from getting mapped.

Yeah, the comments indicate it was first used for dentries.

I wonder if it shouldn't be using the NULL page instead? (ie 0-4095)

-- 
SUSE Labs, Novell Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/