linux-kernel - Re: [Devel] Re: [PATCH] bluetooth bnep: Convert to kthread API.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Apr 2007 12:20:36 +0200
From:	Cedric Le Goater <clg@...ibm.com>
To:	devel@...nvz.org
CC:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Christoph@...p2.linux-foundation.org,
	Holtmann <marcel@...tmann.org>, linux-kernel@...r.kernel.org,
	Hellwig <hch@...radead.org>, containers@...ts.osdl.org,
	Marcel@...p2.linux-foundation.org, Oleg Nesterov <oleg@...sign.ru>
Subject: Re: [Devel] Re: [PATCH] bluetooth bnep: Convert to kthread API.

Andrew Morton wrote:
> On Thu, 19 Apr 2007 01:58:51 -0600
> "Eric W. Biederman" <ebiederm@...ssion.com> wrote:
> 
>> From: Eric W. Biederman <ebiederm@...ssion.com>
>>
>> This patch starts kbenpd using kthread_run replacing
>> a combination of kernel_thread and daemonize.  Making
>> the code a little simpler and more maintainable.
>>
>>
> 
> 	while (!atomic_read(&s->killed)) {
> 
> ho hum.


yes. we need something like :

-       while (!atomic_read(&s->killed)) {
+       while (1) {
                try_to_freeze();
 
                set_current_state(TASK_INTERRUPTIBLE);
 
+               if (atomic_read(&s->killed))
+                       break;
+

I have an old patch for this driver. I'll refresh it.

>> +	task = kthread_run(bnep_session, s, "kbnepd %s", dev->name);
> 
> It's unusual to have a kernel thread which has a space in its name.  That
> could trip up infufficient-defensive userspace tools.

but we can't just change it, can we ? i could be used by a user space tool 
to check if the thread is running.

C.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/