linux-kernel - Re: [PATCH] Transparently handle <.symbol> lookup for kprobes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Apr 2007 15:59:45 +1000
From:	Paul Mackerras <paulus@...ba.org>
To:	Srinivasa Ds <srinivasa@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, ananth@...ibm.com,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Transparently handle <.symbol> lookup for kprobes

Srinivasa Ds writes:

> +	} else {							\
> +		char dot_name[KSYM_NAME_LEN+1];				\
> +		dot_name[0] = '.';					\
> +		dot_name[1] = '\0';					\
> +		strncat(dot_name, name, KSYM_NAME_LEN);			\

Assuming the kernel strncat works like the userspace one does, there
is a possibility that dot_name[] won't be properly null-terminated
here.  If strlen(name) >= KSYM_NAME_LEN-1, then strncat will set
dot_name[KSYM_NAME_LEN-1] to something non-null and won't touch
dot_name[KSYM_NAME_LEN].

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/