linux-kernel - Re: W1 printk format warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Apr 2007 22:17:44 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Dan Williams <dan.j.williams@...el.com>
Subject: Re: W1 printk format warning

On Wed, Apr 25, 2007 at 04:45:09PM -0700, Andrew Morton (akpm@...ux-foundation.org) wrote:
> On Wed, 25 Apr 2007 16:21:04 -0700 Randy Dunlap <randy.dunlap@...cle.com> wrote:
> 
> > in 2.6.21-rc7-mm1.  Are you aware of this?
> > 
> > drivers/w1/w1.c:460: warning: too few arguments for format
> > 
> > 	dev_dbg(&sl->dev, "%s: registering %s as %p.\n", __func__,
> > 		&sl->dev.bus_id[0]);
> > 
> 
> Yeah, that's because Dan's dev_dbg-check-dev_dbg-arguments.patch added
> printk arg-checking to dev_dbg() and a bunch of bugs got exposed.  I fixed
> a few of them.

Could you post a full list for w1, if there is only one, here is a fix.

Thanks a lot, Randy.

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 63c0724..7d6876d 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -459,7 +459,7 @@ static int __w1_attach_slave_device(struct w1_slave *sl)
 		 (unsigned long long) sl->reg_num.id);
 
 	dev_dbg(&sl->dev, "%s: registering %s as %p.\n", __func__,
-		&sl->dev.bus_id[0]);
+		&sl->dev.bus_id[0], sl);
 
 	err = device_register(&sl->dev);
 	if (err < 0) {
-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/