linux-kernel - [patch] uml: remove #warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Apr 2007 18:19:48 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	jdike@...toit.com
CC:	linux-kernel@...r.kernel.org,
	user-mode-linux-devel@...ts.sourceforge.net
Subject: [patch] uml: remove #warnings

From: Miklos Szeredi <mszeredi@...e.cz>

These haven't been fixed for ages.  Just make comments out of them.

arch/um/kernel/skas/process.c:181:2: warning: #warning Need to look up userspace_pid by cpu
arch/um/kernel/skas/process.c:187:2: warning: #warning Need to look up userspace_pid by cpu
arch/um/kernel/skas/process.c:194:2: warning: #warning need to loop over userspace_pids in kill_off_processes_skas

Signed-off-by: Miklos Szeredi <mszeredi@...e.cz>
---

Index: linux/arch/um/kernel/skas/process.c
===================================================================
--- linux.orig/arch/um/kernel/skas/process.c	2007-04-26 15:12:23.000000000 +0200
+++ linux/arch/um/kernel/skas/process.c	2007-04-26 15:12:51.000000000 +0200
@@ -178,20 +178,23 @@ int start_uml_skas(void)
 
 int external_pid_skas(struct task_struct *task)
 {
-#warning Need to look up userspace_pid by cpu
+	/* FIXME: Need to look up userspace_pid by cpu */
 	return(userspace_pid[0]);
 }
 
 int thread_pid_skas(struct task_struct *task)
 {
-#warning Need to look up userspace_pid by cpu
+	/* FIXME: Need to look up userspace_pid by cpu */
 	return(userspace_pid[0]);
 }
 
 void kill_off_processes_skas(void)
 {
 	if(proc_mm)
-#warning need to loop over userspace_pids in kill_off_processes_skas
+		/*
+		 * FIXME: need to loop over userspace_pids in
+		 * kill_off_processes_skas
+		 */
 		os_kill_ptraced_process(userspace_pid[0], 1);
 	else {
 		struct task_struct *p;
Index: linux/arch/um/os-Linux/skas/mem.c
===================================================================
--- linux.orig/arch/um/os-Linux/skas/mem.c	2007-04-26 14:20:23.000000000 +0200
+++ linux/arch/um/os-Linux/skas/mem.c	2007-04-26 15:12:51.000000000 +0200
@@ -55,7 +55,7 @@ static inline long do_syscall_stub(struc
 	int pid = mm_idp->u.pid;
 
 	if(proc_mm)
-#warning Need to look up userspace_pid by cpu
+		/* FIXME: Need to look up userspace_pid by cpu */
 		pid = userspace_pid[0];
 
 	multi_count++;
Index: linux/arch/um/os-Linux/skas/process.c
===================================================================
--- linux.orig/arch/um/os-Linux/skas/process.c	2007-04-26 14:20:23.000000000 +0200
+++ linux/arch/um/os-Linux/skas/process.c	2007-04-26 15:12:51.000000000 +0200
@@ -560,7 +560,7 @@ void switch_mm_skas(struct mm_id *mm_idp
 {
 	int err;
 
-#warning need cpu pid in switch_mm_skas
+	/* FIXME: need cpu pid in switch_mm_skas */
 	if(proc_mm){
 		err = ptrace(PTRACE_SWITCH_MM, userspace_pid[0], 0,
 			     mm_idp->u.mm_fd);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/