| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 29 Apr 2007 01:09:53 -0300 From: Henrique de Moraes Holschuh <hmh@....eng.br> To: Adrian Bunk <bunk@...sta.de> Cc: Andrew Morton <akpm@...ux-foundation.org>, lenb@...nel.org, linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org Subject: Re: [-mm patch] make drivers/misc/thinkpad_acpi:fan_mutex static On Sun, 29 Apr 2007, Adrian Bunk wrote: > Forward declarations of static functions (if required) and actual > variables (like fan_mutex) belong into the C file, not the header. Very well. I will fix the mess for 2.6.23, or, time permitting, 2.6.22. > > Maybe I should just break the driver into multiple files in a subdirectory? > > That would certainly make it *much* cleaner... > > But even more in this case, you will not want to have actual variables > or prototypes of static functions in the header file. I would not have to, in that case. The driver would be much easier to write, and I will need to break it in two for an alsa module anyway, might as well break it in one subdriver per file. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists