linux-kernel - Re: [PATCH] tty add compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 02 May 2007 17:03:27 -0600
From:	Paul Fulghum <paulkf@...rogate.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Andrew Morton <akpm@...l.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tty add compat_ioctl method

Arnd Bergmann wrote:
> 
> Looks ok mostly. Just some details:
> ...
>> +#ifdef CONFIG_COMPAT
>> +	long (*compat_ioctl)(struct tty_struct *tty, struct file * file,
>> +			     unsigned int cmd, unsigned long arg);
>> +#endif
> 
> I wouldn't hide this inside of an #ifdef. The structures are all static
> and therefore a single field per driver doesn't add much bload, but
> being able to always assign the .compat_ioctl pointer makes the code
> somewhat nicer

OK

>> --- a/drivers/char/tty_io.c	2006-11-29 15:57:37.000000000 -0600
>> +++ b/drivers/char/tty_io.c	2007-04-30 14:51:01.000000000 -0500
>> @@ -151,6 +151,9 @@ static int tty_open(struct inode *, stru
>>  static int tty_release(struct inode *, struct file *);
>>  int tty_ioctl(struct inode * inode, struct file * file,
>>  	      unsigned int cmd, unsigned long arg);
>> +#ifdef CONFIG_COMPAT
>> +long tty_compat_ioctl(struct file * file, unsigned int cmd, unsigned long arg);
>> +#endif
>>  static int tty_fasync(int fd, struct file * filp, int on);
>>  static void release_mem(struct tty_struct *tty, int idx);
> 
> declarations should never be hidden inside of an #ifdef. If you want to be
> extra clever here, you can do

OK, I have no problem with that.
A declaration without implementation won't generate a warning?

> #ifdef CONFIG_COMPAT
> long tty_compat_ioctl(struct file * file, unsigned int cmd, unsigned long arg);
> #else
> #define tty_compat_ioctl NULL
> #endif
> 
> then you don't need an #ifdef in the code setting the function pointers.

OK

>> +	tty = (struct tty_struct *)file->private_data;
> 
> no need for the cast, ->private_data is void*.

Yes, an easy fix.

--
Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/