linux-kernel - Re: [Patch][SIS USB2VGA] Warning fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 2 May 2007 22:48:41 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	thomas@...ischhofer.net, LKML <linux-kernel@...r.kernel.org>,
	Wang Ya-gang <lazy_linux@....com>,
	Chen Li-jun <cljun@...ou.edu.cn>
Subject: Re: [Patch][SIS USB2VGA] Warning fix

On Thu, 3 May 2007 13:34:29 +0800 WANG Cong <xiyou.wangcong@...il.com> wrote:

> 
> Fix this warning:
> drivers/usb/misc/sisusbvga/sisusb_con.c:1436: warning: initialization from incompatible pointer type
> 
> 
> Signed-off-by: WANG Cong <xiyou.wangcong@...il.com>
> ---
> 
> Compiling test past.;)
> 

Thanks.

> --- linux-2.6.21-rc7-mm2/drivers/usb/misc/sisusbvga/sisusb_con.c.orig	2007-05-03 02:51:06.000000000 +0800
> +++ linux-2.6.21-rc7-mm2/drivers/usb/misc/sisusbvga/sisusb_con.c	2007-05-03 02:57:08.000000000 +0800
> @@ -321,9 +321,10 @@ sisusbcon_deinit(struct vc_data *c)
>  /* interface routine */
>  static u8
>  sisusbcon_build_attr(struct vc_data *c, u8 color, u8 intensity,
> -			    u8 blink, u8 underline, u8 reverse)
> +			    u8 blink, u8 underline, u8 reverse, u8 unused)
>  {
>  	u8 attr = color;
> +	(void) unused;

This part isn't needed and we don't usually do it - the compiler will not warn
about the unused arg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/