linux-kernel - RE: [PATCH 3/3] [POWERPC] dts: kill hardcoded phandles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 May 2007 07:29:20 -0700
From:	"Loeliger Jon-LOELIGER" <jdl@...escale.com>
To:	"David Gibson" <david@...son.dropbear.id.au>,
	"Vitaly Bordug" <vitb@...nel.crashing.org>
Cc:	<linuxppc-dev@...abs.org>, <linux-pcmcia@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/3] [POWERPC] dts: kill hardcoded phandles


> > -       interrupt-controller@...00000 {
> > -               linux,phandle = <f8200000>;
> > +		pci_pic:interrupt-controller@...00000 {
> 
> I'd like to establish a convention of putting a space after the : and
> using capitals for labels unless there's a strong reason not to in a
> particular case.  It makes them easier to visually distinguish next to
> the node name.

Colon-space is easy and I'll buy it.
I'm not big on uppercase shouting, though.

Perhaps something more like case or goto labels:?

    pci_pic:
        interrupt-contoller@...00000 {

if needed?

jdl
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/