linux-kernel - Re: [PATCH 3/6] firewire: char device interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 May 2007 20:19:03 -0400
From:	Kristian Høgsberg <krh@...hat.com>
To:	Christoph Hellwig <hch@...radead.org>,
	Kristian H??gsberg <krh@...hat.com>,
	John Stoffel <john@...ffel.org>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux1394-devel <linux1394-devel@...ts.sourceforge.net>
Subject: Re: [PATCH 3/6] firewire: char device interface

Christoph Hellwig wrote:
> On Wed, May 02, 2007 at 05:11:45PM -0400, Kristian H??gsberg wrote:
>> The firewire-cdev.h file is meant to be a self-contained userspace header 
>> file and shouldn't include other kernel header files.  All duplicated 
>> values are standardized ieee1394 values and won't ever change.  I should 
>> put a #ifndef __FW_COMMON_DEFINES protection around the duplicate values, I 
>> guess, but I'm just wondering why I never saw a "symbol redefined" 
>> warning...
> 
> No, defining things in two places is not okay.  Just add a new header
> that defines these protocol constants, which needs to be included by
> userspace that wants to use them.

Ok, I split out the shared constants into linux/firewire-constants.h which 
gets included by linux/firewire-cdev.h.

Kristian

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/