linux-kernel - Re: [PATCH 8/8] One Laptop Per Child power/battery driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 May 2007 01:20:51 +0200
From:	Pavel Machek <pavel@....cz>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Satyam Sharma <satyam.sharma@...il.com>,
	Anton Vorontsov <cbou@...l.ru>, Greg KH <gregkh@...e.de>,
	linux-kernel@...r.kernel.org, kernel-discuss@...dhelds.org,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH 8/8] One Laptop Per Child power/battery driver

Hi!

> > > > > > And how about serial terminals?
> > > > > 
> > > > > It works fine over serial terminals. Why wouldn't it?
> > > > 
> > > > He probably means serial terminals... like physical vt100. I used to
> > > > have one (vt302 compatible or something).  Most emulators still
> > > > emulate vt100, and yes, vt100 predates utf-8. 
> > > 
> > > I have a serial terminal which can only do lower case (well, actually
> > > capitals but it's all mapped to lower case since that's more useful).
> > > 
> > > When I write code on it, I can't do capital letters. But do I try to
> > > _force_ you to use only capitals because of my limited terminal?
> > 
> > If I wrote int j, J; in my code, you'd have valid case wanting me to
> > fix it. And I simply want you to fix useless uses of utf-8. And evil
> > uses utf8, like int voltage; /* ??V */. I do not know what is so hard
> > to understand.
> > 
> > You are intentionally making code hard to read. Stop trying to merge
> > that crap.
> 
> It was °C, and that's IMHO better readable than some kind of
> "degrees C".

It is more readable for you, and more readable on me while in desktop
X. But on Zaurus and on console I see "???C", and I definitely prefer
"degrees C" to _that_.

And I'm clearly not alone.

> Only using 7bit ASCII might have been a good advice in the last 
> millenium. But in the current millenium, most environments handle UTF-8 
> just fine.

Common denominator should be used. That includes 80 columns.

> And we are only talking about documentation and comments - IOW, things 
> not visible for someone running a kernel. Code (including printk's) must 
> stay 7bit ASCII.

Yes, something that cafe driver breaks... it identifies to userland as
"caf???"... but that's another story.

I'd add that variable names must be 7bit ASCII.

> In the worst case, if you managed to find a not UTF-8 capable 
> environment for viewing the kernel sources, the few characters that are 
> not 7bit ASCII are displayed incorrectly, and you'll have to guess which 
> character someone might place in front of a "C" describing something 
> named wBAT_TEMP (you will likely guess it correctly).

Yes, but it would be better to avoid it.. and guessing is much harder
for ???V case (same driver).

I do not think using comments people can actually _read_ is that much
to ask.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/