linux-kernel - Re: [PATCH] LogFS take three

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 May 2007 15:36:44 +0300
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Jörn Engel" <joern@...ybastard.org>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mtd@...ts.infradead.org, akpm@...l.org,
	"Albert Cahalan" <acahalan@...il.com>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Jan Engelhardt" <jengelh@...ux01.gwdg.de>,
	"Evgeniy Polyakov" <johnpol@....mipt.ru>,
	"Greg KH" <greg@...ah.com>, "Ingo Oeser" <ioe-lkml@...eria.de>
Subject: Re: [PATCH] LogFS take three

On 5/16/07, Jörn Engel <joern@...ybastard.org> wrote:
> > > +/* FIXME: all this mess should get replaced by using the page cache */
> > > +static void fixup_from_wbuf(struct super_block *sb, struct logfs_area
> > *area,
> > > +             void *read, u64 ofs, size_t readlen)
> > > +{
> >
> > Indeed. And I think you're getting some more trouble because of this...
>
> More trouble?

Forgot to add (see below). Seems logfs_segment_read would be simpler
too if you fixed this.

> [ Objects are the units that get compressed.  Segments can contain both
> compressed and uncompressed objects. ]
>
> It is a trade-off.  Each object has a 24 Byte header plus X Bytes of
> data.  Whether the data is compressed or not is indicated in the header.

Was my point really. Why do segments contain both compressed and
uncompressed objects?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/